On 4/8/20 11:00 AM, Frank Rowand wrote:
> On 3/30/20 5:05 AM, Ding Xiang wrote:
>> rc is unneeded, just return 0.
>
> of: of_detach_node() remove unneeded local return variable
never mind, this is not the subject line... My mistake.
-Frank
>
>>
>> Signed-off-by: Ding Xiang <dingxiang@xxxxxxxxxxxxxxxxxxxx>
>> ---
>> drivers/of/dynamic.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c
>> index 08fd823..fe64430 100644
>> --- a/drivers/of/dynamic.c
>> +++ b/drivers/of/dynamic.c
>> @@ -286,7 +286,6 @@ int of_detach_node(struct device_node *np)
>> {
>> struct of_reconfig_data rd;
>> unsigned long flags;
>> - int rc = 0;
>>
>> memset(&rd, 0, sizeof(rd));
>> rd.dn = np;
>> @@ -301,7 +300,7 @@ int of_detach_node(struct device_node *np)
>>
>> of_reconfig_notify(OF_RECONFIG_DETACH_NODE, &rd);
>>
>> - return rc;
>> + return 0;
>> }
>> EXPORT_SYMBOL_GPL(of_detach_node);
>>
>>
>
>
> Reviewed-by: Frank Rowand <frank.rowand@xxxxxxxx>
>
