On Mon, Mar 09, 2020 at 08:42:41PM +0100, Lubomir Rintel wrote: > The clk-of-mmp2 driver pretends that the clock outputs from the PLLs are > constant, but in fact they are configurable. > > Add logic for obtaining the actual clock rates on MMP2 as well as MMP3. > There is no documentation for either SoC, but the "systemsetting" drivers > from Marvell GPL code dump provide some clue as far as MPMU registers on > MMP2 [1] and MMP3 [2] go. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/lkundrak/linux-mmp3-dell-ariel.git/tree/drivers/char/mmp2_systemsetting.c > [2] https://git.kernel.org/pub/scm/linux/kernel/git/lkundrak/linux-mmp3-dell-ariel.git/tree/drivers/char/mmp3_systemsetting.c > > A separate commit will adjust the clk-of-mmp2 driver. > > Tested on a MMP3-based Dell Wyse 3020 as well as MMP2-based OLPC > XO-1.75 laptop. > > Signed-off-by: Lubomir Rintel <lkundrak@xxxxx> This patch results in: arm-linux-gnueabi-ld: drivers/clk/mmp/clk.o: in function `mmp_register_pll_clks': drivers/clk/mmp/clk.c:192: undefined reference to `mmp_clk_register_pll' when building arm:pxa910_defconfig. Bisect log is attached. Guenter --- # bad: [a10c9c710f9ecea87b9f4bbb837467893b4bef01] Merge tag 'for-v5.7' of git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply # good: [4c205c84e249e0a91dcfabe461d77667ec9b2d05] Merge tag 'keys-fixes-20200329' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs git bisect start 'a10c9c710f9e' '4c205c84e249' # bad: [31c0aa87ec8a30b1e9e4cf862905a369560f7705] Merge tag 'random_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/random git bisect bad 31c0aa87ec8a30b1e9e4cf862905a369560f7705 # bad: [53a2cc5cc36fd97728e1b418dbfa8f70bf23391a] Merge branches 'clk-ti', 'clk-ingenic', 'clk-typo', 'clk-at91', 'clk-mmp2' and 'clk-arm-icst' into clk-next git bisect bad 53a2cc5cc36fd97728e1b418dbfa8f70bf23391a # good: [2d11e9a1fd2abe784b334442b36f7d83ff914287] Merge branches 'clk-phase-errors', 'clk-amlogic', 'clk-renesas' and 'clk-allwinner' into clk-next git bisect good 2d11e9a1fd2abe784b334442b36f7d83ff914287 # bad: [de17be999cb07effacf6a1129602f63396f5af27] clk: mmp2: Fix bit masks for LCDC I/O and pixel clocks git bisect bad de17be999cb07effacf6a1129602f63396f5af27 # bad: [4d6da655d1871fadcb2b5de086e5a35883e22c95] dt-bindings: marvell,mmp2: Add clock ids for MMP3 PLLs git bisect bad 4d6da655d1871fadcb2b5de086e5a35883e22c95 # bad: [5d34d0b32d6c13947b0aa890fc4c68f203491169] clk: mmp2: Add support for PLL clock sources git bisect bad 5d34d0b32d6c13947b0aa890fc4c68f203491169 # good: [cb8dbfe831758fb2ba52d8c30db5249e48f57b8b] clk: mmp2: Constify some strings git bisect good cb8dbfe831758fb2ba52d8c30db5249e48f57b8b # good: [7de0b8b8b0508af5fed2f2a07e3abb6acac0c466] dt-bindings: clock: Convert marvell,mmp2-clock to json-schema git bisect good 7de0b8b8b0508af5fed2f2a07e3abb6acac0c466 # first bad commit: [5d34d0b32d6c13947b0aa890fc4c68f203491169] clk: mmp2: Add support for PLL clock sources
