Hi!
> > > arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dt.yaml: leds:
> > > diy-led:linux,default-trigger:0: 'mmc2' is not one of ['backlight',
> > > 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> > > arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dt.yaml: leds:
> > > yellow-led:linux,default-trigger:0: 'mmc1' is not one of ['backlight',
> > > 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> >
> > Maybe we should just get rid of linux,default-trigger then?
>
> In this particular case, I'd say it's probably time to reevaluate the rather
> out-of-date binding. The apparent intent of the "linux,default-trigger"
> property seems to be to describe any trigger supported by Linux, so either
> the binding wants to be kept in sync with all the triggers Linux actually
> supports, or perhaps it should just be redefined as a free-form
It is enough to keep it in sync with all the triggers we actually use :-).
> I'd be slightly inclined towards the latter, since the schema validator
> can't know whether the given trigger actually corresponds to the correct
> thing for whatever the LED is physically labelled on the board/case, nor
> whether the version(s) of Linux that people intend to use actually support
> that trigger (since it doesn't have to be the version contemporary with the
> schema definition), so strict validation of this particular property seems
> to be of limited value.
But freeform seems acceptable, too.
> > > > - diy-led {
> > > > + diy_led: diy-led {
> > > > label = "red:diy";
> > > > gpios = <&gpio0 RK_PB5 GPIO_ACTIVE_HIGH>;
> > > > default-state = "off";
> > > > linux,default-trigger = "mmc1";
> > > > };
This label probably should be "mmc1:red:activity" or something like that.
> > > > - yellow-led {
> > > > + yellow_led: yellow-led {
> > > > label = "yellow:yellow-led";
> > > > gpios = <&gpio0 RK_PA2 GPIO_ACTIVE_HIGH>;
> > > > default-state = "off";
And this label should be changed, too.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: PGP signature
