Hi,
On Thu, Apr 2, 2020 at 2:39 PM John Stultz <john.stultz@xxxxxxxxxx> wrote:
>
> On Mon, Mar 9, 2020 at 2:54 AM Sandeep Maheswaram <sanm@xxxxxxxxxxxxxx> wrote:
> > @@ -774,8 +774,8 @@ static const struct of_device_id qusb2_phy_of_match_table[] = {
> > .compatible = "qcom,msm8998-qusb2-phy",
> > .data = &msm8998_phy_cfg,
> > }, {
> > - .compatible = "qcom,sdm845-qusb2-phy",
> > - .data = &sdm845_phy_cfg,
> > + .compatible = "qcom,qusb2-v2-phy",
> > + .data = &qusb2_v2_phy_cfg,
> > },
> > { },
> > };
>
> Just as a heads up, Yongqin (cc'ed) reported this patch (now upstream)
> seems to be causing trouble on the db845c.
>
> It seems like its removing support for the "qcom,sdm845-qusb2-phy"
> compatible string, which is documented:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml#n23
>
> and already in use:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sdm845.dtsi#n2389
>
> Should this instead have been an addition of the "qcom,qusb2-v2-phy",
> line instead of replacing "qcom,sdm845-qusb2-phy"?
To avoid forking the discussion into two threads, I'll suggest that we
focus on keeping the discussion in reply to your newly proposed patch.
I've already replied there:
https://lore.kernel.org/r/CAD=FV=VGT75c4_ErQAJgNtcCd2Jzv0A2KpfEkS637GqOhamj9Q@xxxxxxxxxxxxxx
-Doug
