>>On Tue, Mar 31, 2020 at 02:32:02PM +0300, amirmizi6@xxxxxxxxx wrote: >> From: Amir Mizinski <amirmizi6@xxxxxxxxx> >> >> In order to compute the crc over the data sent in lower layer (I2C >> for instance), tpm_tis_check_data() calls an operation (if available) >> to check data integrity. If data integrity cannot be verified, a retry >> attempt to save the sent/received data is implemented. >> >> The current steps are done when sending a command: >> 1. Host writes to TPM_STS.commandReady. >> 2. Host writes command. >> 3. Host checks that TPM received data is valid. >> 4. If data is currupted go to step 1. >> >> When receiving data: >> 1. Host checks that TPM_STS.dataAvail is set. >> 2. Host saves received data. >> 3. Host checks that received data is correct. >> 4. If data is currupted Host writes to TPM_STS.responseRetry and go to >> step 1. >> >> Co-developed-by: Christophe Richard <hristophe-h.ricard@xxxxxx> >> Signed-off-by: Christophe Richard <hristophe-h.ricard@xxxxxx> >> Signed-off-by: Amir Mizinski <amirmizi6@xxxxxxxxx> >The email is malformed. >So.. How did Christophe participate on writing this patch? I haven't seen him shouting anything about the subject and still his SOB is there. >/Jarkko Christophe sent patch to support I2C TCG TPM driver tpm_tis_i2c (https://patchwork.kernel.org/patch/8628681/) in the same time that tpm_tis_spi. This function was named tpm_tis_i2c_check_data. Best Regards,