Re: [PATCH v5 2/2] iio: proximity: Add driver support for vcnl3020 proximity sensor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 31, 2020 at 7:56 PM Ivan Mikhaylov <i.mikhaylov@xxxxxxxxx> wrote:
> On Tue, 2020-03-31 at 14:00 +0300, Andy Shevchenko wrote:
> > > > Why not to use standard pattern, i.e.
> > > >
> > > >   if (rc)
> > > >     return rc;
> > > >   ...
> > > >   rc = regmap_write(...);
> > > >
> > > > ?
> > >
> > > Optional parameter. There exists a lot of ways to do it:
> >
> > I'm simple reading the code. And I believe the above I suggested is
> > cleaner equivalent.
> > Is it?
> >
> > > rc = device_property_read_u32(dev, "milliamp", &led_current);
> > > rc = regmap_write(regmap, VCNL_LED_CURRENT, (!rc) : led_current ? 0);
> >
> > This seems not equal to above.
>
> Yes, it is not equal. Error will be returned in case of non existent parameter
> in vcnl3020_init but parameter is optional. rc shouldn't be checked

Ah it makes sense.

> or should
> return 0 with your suggestion.
>
> rc = device_property_read_u32(...);
> if (rc)
>         return 0;
> rc = regmap_write(...);
> if (rc)
>         dev_err(...);
> return rc;

In case we would like to have more optional parameters above will be a burden.
Perhaps

static int get_and_apply_property_x(...)
{
  ...Above code...
}

...and in the function

rc = get_and_apply_property_x(...)
if (rc)
  return rc;

or if it's the last one,

return get_and_apply_property_x(...);

-- 
With Best Regards,
Andy Shevchenko



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux