On Sun, Mar 29, 2020 at 1:04 PM Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > > Hi Rob. > > > > + > > > + mode-gpios: > > > + description: | > > > + GPIO ordered MO, LR, and UD as specified in LS037V7DW01.pdf > > > > 3 or... > > > > > + change configuration between QVGA and VGA mode and the > > > + scan direction. As these pins can be also configured > > > + with external pulls, all the GPIOs are considered > > > + optional with holes in the array. > > > > minItems: 3 > > maxItems: 5 > > This binding can specify up to three GPIOs like this: So it should be: minItems: 1 maxItems: 3 > > > + mode-gpios = <&gpio5 26 GPIO_ACTIVE_HIGH /* gpio154, lcd MO */ > > > + &gpio1 2 GPIO_ACTIVE_HIGH /* gpio2, lcd LR */ > > > + &gpio1 3 GPIO_ACTIVE_HIGH>; /* gpio3, lcd UD */ > > They are in the linux kernel driver accessed like this: > > devm_gpiod_get_index(&pdev->dev, "mode", 2, GPIOD_OUT_LOW); > > The following is OK in the DT file: > > mode-gpios = <&gpio5 26 GPIO_ACTIVE_HIGH>; > > mode-gpios = <&gpio5 26 GPIO_ACTIVE_HIGH > &gpio1 2 GPIO_ACTIVE_HIGH>; > > mode-gpios = <&gpio5 26 GPIO_ACTIVE_HIGH > &gpio1 2 GPIO_ACTIVE_HIGH > &gpio1 3 GPIO_ACTIVE_HIGH>; With the above, the 2nd 2 should fail... > But the following is not OK: > mode-gpios = <&gpio5 26 GPIO_ACTIVE_HIGH>, <&gpio1 2 GPIO_ACTIVE_HIGH>; And this should pass. We want phandle+arg type properties to be bracketed like this. If that's not working, then it's a bug in the tooling. Please confirm and I'll investigate. Rob
