> Subject: Re: [RFC net-next 3/5] arm64: dts: lx2160a: add PCS MDIO nodes > > On Thu, Mar 26, 2020 at 09:14:13PM +0000, Ioana Ciornei wrote: > > > Subject: [RFC net-next 3/5] arm64: dts: lx2160a: add PCS MDIO nodes > > > > > > *NOT FOR MERGING* > > > > > > Add PCS MDIO nodes for the LX2160A, which will be used when the MAC > > > is in PHY mode and is using in-band negotiation. > > > > > > Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx> > > > --- > > > .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 144 > > > ++++++++++++++++++ > > > 1 file changed, 144 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > > > b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > > > index e5ee5591e52b..732af33eec18 100644 > > > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > > > @@ -960,6 +960,132 @@ > > > status = "disabled"; > > > }; > > > > > > + pcs_mdio1: mdio@8c07000 { > > > + compatible = "fsl,fman-memac-mdio"; > > > + reg = <0x0 0x8c07000 0x0 0x1000>; > > > + little-endian; > > > + status = "disabled"; > > > + }; > > > > Are the PCS MDIO buses shareable? I am asking this because in case of QSGMII > our structure is a little bit quirky. > > There are 4 MACs but all PCSs sit on the first MACs internal MDIO bus only. The > other 3 internal MDIO buses are empty. > > I haven't looked at QSGMII yet, I've only considered single-lane setups and only > implemented that. For _this_ part, it doesn't matter as this is just declaring > where the hardware is. I think that matters more for the dpmac nodes. Sorry for misplacing the comment. I am going to take a look tomorrow and see how workable this approach is going to be in the long term since I have a board with QSGMII handy. > > > > + > > > + pcs_mdio2: mdio@8c0b000 { > > > + compatible = "fsl,fman-memac-mdio"; > > > + reg = <0x0 0x8c0b000 0x0 0x1000>; > > > + little-endian; > > > + status = "disabled"; > > > + }; > > > + > > > + pcs_mdio3: mdio@8c0f000 { > > > + compatible = "fsl,fman-memac-mdio"; > > > + reg = <0x0 0x8c0f000 0x0 0x1000>; > > > + little-endian; > > > + status = "disabled"; > > > + }; > > > + > > > + pcs_mdio4: mdio@8c13000 { > > > + compatible = "fsl,fman-memac-mdio"; > > > + reg = <0x0 0x8c13000 0x0 0x1000>; > > > + little-endian; > > > + status = "disabled"; > > > + }; > > > + > > > + pcs_mdio5: mdio@8c17000 { > > > + compatible = "fsl,fman-memac-mdio"; > > > + reg = <0x0 0x8c17000 0x0 0x1000>; > > > + little-endian; > > > + status = "disabled"; > > > + }; > > > + > > > + pcs_mdio6: mdio@8c1b000 { > > > + compatible = "fsl,fman-memac-mdio"; > > > + reg = <0x0 0x8c1b000 0x0 0x1000>; > > > + little-endian; > > > + status = "disabled"; > > > + }; > > > + > > > + pcs_mdio7: mdio@8c1f000 { > > > + compatible = "fsl,fman-memac-mdio"; > > > + reg = <0x0 0x8c1f000 0x0 0x1000>; > > > + little-endian; > > > + status = "disabled"; > > > + }; > > > + > > > + pcs_mdio8: mdio@8c23000 { > > > + compatible = "fsl,fman-memac-mdio"; > > > + reg = <0x0 0x8c23000 0x0 0x1000>; > > > + little-endian; > > > + status = "disabled"; > > > + }; > > > + > > > + pcs_mdio9: mdio@8c27000 { > > > + compatible = "fsl,fman-memac-mdio"; > > > + reg = <0x0 0x8c27000 0x0 0x1000>; > > > + little-endian; > > > + status = "disabled"; > > > + }; > > > + > > > + pcs_mdio10: mdio@8c2b000 { > > > + compatible = "fsl,fman-memac-mdio"; > > > + reg = <0x0 0x8c2b000 0x0 0x1000>; > > > + little-endian; > > > + status = "disabled"; > > > + }; > > > + > > > + pcs_mdio11: mdio@8c2f000 { > > > + compatible = "fsl,fman-memac-mdio"; > > > + reg = <0x0 0x8c2f000 0x0 0x1000>; > > > + little-endian; > > > + status = "disabled"; > > > + }; > > > + > > > + pcs_mdio12: mdio@8c33000 { > > > + compatible = "fsl,fman-memac-mdio"; > > > + reg = <0x0 0x8c33000 0x0 0x1000>; > > > + little-endian; > > > + status = "disabled"; > > > + }; > > > + > > > + pcs_mdio13: mdio@8c37000 { > > > + compatible = "fsl,fman-memac-mdio"; > > > + reg = <0x0 0x8c37000 0x0 0x1000>; > > > + little-endian; > > > + status = "disabled"; > > > + }; > > > + > > > + pcs_mdio14: mdio@8c3b000 { > > > + compatible = "fsl,fman-memac-mdio"; > > > + reg = <0x0 0x8c3b000 0x0 0x1000>; > > > + little-endian; > > > + status = "disabled"; > > > + }; > > > + > > > + pcs_mdio15: mdio@8c3f000 { > > > + compatible = "fsl,fman-memac-mdio"; > > > + reg = <0x0 0x8c3f000 0x0 0x1000>; > > > + little-endian; > > > + status = "disabled"; > > > + }; > > > + > > > + pcs_mdio16: mdio@8c43000 { > > > + compatible = "fsl,fman-memac-mdio"; > > > + reg = <0x0 0x8c43000 0x0 0x1000>; > > > + little-endian; > > > + status = "disabled"; > > > + }; > > > + > > > + pcs_mdio17: mdio@8c47000 { > > > + compatible = "fsl,fman-memac-mdio"; > > > + reg = <0x0 0x8c47000 0x0 0x1000>; > > > + little-endian; > > > + status = "disabled"; > > > + }; > > > + > > > + pcs_mdio18: mdio@8c4b000 { > > > + compatible = "fsl,fman-memac-mdio"; > > > + reg = <0x0 0x8c4b000 0x0 0x1000>; > > > + little-endian; > > > + status = "disabled"; > > > + }; > > > + > > > > Please sort the nodes alphabetically. > > Huh? The nodes in this file are already sorted according to address, and this > patch preserves that sorting. The hex address field also happens to be > alphabetical. > > Or do you mean the label for these modes - I've never heard of sorting by label > for a SoC file. Uhh, I remember now. For some reason I thought this was a board file. Ioana [snip]