> Subject: [RFC net-next 3/5] arm64: dts: lx2160a: add PCS MDIO nodes
>
> *NOT FOR MERGING*
>
> Add PCS MDIO nodes for the LX2160A, which will be used when the MAC is in
> PHY mode and is using in-band negotiation.
>
> Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx>
> ---
> .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 144 ++++++++++++++++++
> 1 file changed, 144 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> index e5ee5591e52b..732af33eec18 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> @@ -960,6 +960,132 @@
> status = "disabled";
> };
>
> + pcs_mdio1: mdio@8c07000 {
> + compatible = "fsl,fman-memac-mdio";
> + reg = <0x0 0x8c07000 0x0 0x1000>;
> + little-endian;
> + status = "disabled";
> + };
Are the PCS MDIO buses shareable? I am asking this because in case of QSGMII our structure is a little bit quirky.
There are 4 MACs but all PCSs sit on the first MACs internal MDIO bus only. The other 3 internal MDIO buses are empty.
> +
> + pcs_mdio2: mdio@8c0b000 {
> + compatible = "fsl,fman-memac-mdio";
> + reg = <0x0 0x8c0b000 0x0 0x1000>;
> + little-endian;
> + status = "disabled";
> + };
> +
> + pcs_mdio3: mdio@8c0f000 {
> + compatible = "fsl,fman-memac-mdio";
> + reg = <0x0 0x8c0f000 0x0 0x1000>;
> + little-endian;
> + status = "disabled";
> + };
> +
> + pcs_mdio4: mdio@8c13000 {
> + compatible = "fsl,fman-memac-mdio";
> + reg = <0x0 0x8c13000 0x0 0x1000>;
> + little-endian;
> + status = "disabled";
> + };
> +
> + pcs_mdio5: mdio@8c17000 {
> + compatible = "fsl,fman-memac-mdio";
> + reg = <0x0 0x8c17000 0x0 0x1000>;
> + little-endian;
> + status = "disabled";
> + };
> +
> + pcs_mdio6: mdio@8c1b000 {
> + compatible = "fsl,fman-memac-mdio";
> + reg = <0x0 0x8c1b000 0x0 0x1000>;
> + little-endian;
> + status = "disabled";
> + };
> +
> + pcs_mdio7: mdio@8c1f000 {
> + compatible = "fsl,fman-memac-mdio";
> + reg = <0x0 0x8c1f000 0x0 0x1000>;
> + little-endian;
> + status = "disabled";
> + };
> +
> + pcs_mdio8: mdio@8c23000 {
> + compatible = "fsl,fman-memac-mdio";
> + reg = <0x0 0x8c23000 0x0 0x1000>;
> + little-endian;
> + status = "disabled";
> + };
> +
> + pcs_mdio9: mdio@8c27000 {
> + compatible = "fsl,fman-memac-mdio";
> + reg = <0x0 0x8c27000 0x0 0x1000>;
> + little-endian;
> + status = "disabled";
> + };
> +
> + pcs_mdio10: mdio@8c2b000 {
> + compatible = "fsl,fman-memac-mdio";
> + reg = <0x0 0x8c2b000 0x0 0x1000>;
> + little-endian;
> + status = "disabled";
> + };
> +
> + pcs_mdio11: mdio@8c2f000 {
> + compatible = "fsl,fman-memac-mdio";
> + reg = <0x0 0x8c2f000 0x0 0x1000>;
> + little-endian;
> + status = "disabled";
> + };
> +
> + pcs_mdio12: mdio@8c33000 {
> + compatible = "fsl,fman-memac-mdio";
> + reg = <0x0 0x8c33000 0x0 0x1000>;
> + little-endian;
> + status = "disabled";
> + };
> +
> + pcs_mdio13: mdio@8c37000 {
> + compatible = "fsl,fman-memac-mdio";
> + reg = <0x0 0x8c37000 0x0 0x1000>;
> + little-endian;
> + status = "disabled";
> + };
> +
> + pcs_mdio14: mdio@8c3b000 {
> + compatible = "fsl,fman-memac-mdio";
> + reg = <0x0 0x8c3b000 0x0 0x1000>;
> + little-endian;
> + status = "disabled";
> + };
> +
> + pcs_mdio15: mdio@8c3f000 {
> + compatible = "fsl,fman-memac-mdio";
> + reg = <0x0 0x8c3f000 0x0 0x1000>;
> + little-endian;
> + status = "disabled";
> + };
> +
> + pcs_mdio16: mdio@8c43000 {
> + compatible = "fsl,fman-memac-mdio";
> + reg = <0x0 0x8c43000 0x0 0x1000>;
> + little-endian;
> + status = "disabled";
> + };
> +
> + pcs_mdio17: mdio@8c47000 {
> + compatible = "fsl,fman-memac-mdio";
> + reg = <0x0 0x8c47000 0x0 0x1000>;
> + little-endian;
> + status = "disabled";
> + };
> +
> + pcs_mdio18: mdio@8c4b000 {
> + compatible = "fsl,fman-memac-mdio";
> + reg = <0x0 0x8c4b000 0x0 0x1000>;
> + little-endian;
> + status = "disabled";
> + };
> +
Please sort the nodes alphabetically.
> fsl_mc: fsl-mc@80c000000 {
> compatible = "fsl,qoriq-mc";
> reg = <0x00000008 0x0c000000 0 0x40>, @@ -988,91
> +1114,109 @@
> dpmac1: dpmac@1 {
> compatible = "fsl,qoriq-mc-dpmac";
> reg = <0x1>;
> + pcs-mdio = <&pcs_mdio1>;
> };
>
> dpmac2: dpmac@2 {
> compatible = "fsl,qoriq-mc-dpmac";
> reg = <0x2>;
> + pcs-mdio = <&pcs_mdio2>;
> };
>
> dpmac3: dpmac@3 {
> compatible = "fsl,qoriq-mc-dpmac";
> reg = <0x3>;
> + pcs-mdio = <&pcs_mdio3>;
> };
>
> dpmac4: dpmac@4 {
> compatible = "fsl,qoriq-mc-dpmac";
> reg = <0x4>;
> + pcs-mdio = <&pcs_mdio4>;
> };
>
> dpmac5: dpmac@5 {
> compatible = "fsl,qoriq-mc-dpmac";
> reg = <0x5>;
> + pcs-mdio = <&pcs_mdio5>;
> };
>
> dpmac6: dpmac@6 {
> compatible = "fsl,qoriq-mc-dpmac";
> reg = <0x6>;
> + pcs-mdio = <&pcs_mdio6>;
> };
>
> dpmac7: dpmac@7 {
> compatible = "fsl,qoriq-mc-dpmac";
> reg = <0x7>;
> + pcs-mdio = <&pcs_mdio7>;
> };
>
> dpmac8: dpmac@8 {
> compatible = "fsl,qoriq-mc-dpmac";
> reg = <0x8>;
> + pcs-mdio = <&pcs_mdio8>;
> };
>
> dpmac9: dpmac@9 {
> compatible = "fsl,qoriq-mc-dpmac";
> reg = <0x9>;
> + pcs-mdio = <&pcs_mdio9>;
> };
>
> dpmac10: dpmac@a {
> compatible = "fsl,qoriq-mc-dpmac";
> reg = <0xa>;
> + pcs-mdio = <&pcs_mdio10>;
> };
>
> dpmac11: dpmac@b {
> compatible = "fsl,qoriq-mc-dpmac";
> reg = <0xb>;
> + pcs-mdio = <&pcs_mdio11>;
> };
>
> dpmac12: dpmac@c {
> compatible = "fsl,qoriq-mc-dpmac";
> reg = <0xc>;
> + pcs-mdio = <&pcs_mdio12>;
> };
>
> dpmac13: dpmac@d {
> compatible = "fsl,qoriq-mc-dpmac";
> reg = <0xd>;
> + pcs-mdio = <&pcs_mdio13>;
> };
>
> dpmac14: dpmac@e {
> compatible = "fsl,qoriq-mc-dpmac";
> reg = <0xe>;
> + pcs-mdio = <&pcs_mdio14>;
> };
>
> dpmac15: dpmac@f {
> compatible = "fsl,qoriq-mc-dpmac";
> reg = <0xf>;
> + pcs-mdio = <&pcs_mdio15>;
> };
>
> dpmac16: dpmac@10 {
> compatible = "fsl,qoriq-mc-dpmac";
> reg = <0x10>;
> + pcs-mdio = <&pcs_mdio16>;
> };
>
> dpmac17: dpmac@11 {
> compatible = "fsl,qoriq-mc-dpmac";
> reg = <0x11>;
> + pcs-mdio = <&pcs_mdio17>;
> };
>
> dpmac18: dpmac@12 {
> compatible = "fsl,qoriq-mc-dpmac";
> reg = <0x12>;
> + pcs-mdio = <&pcs_mdio18>;
> };
> };
> };
> --
> 2.20.1
