Hi Rob, On 20/03/20 11:29 pm, Rob Herring wrote: > > On Wed, Mar 11, 2020 at 12:18:50PM +0000, Ajay.Kathat@xxxxxxxxxxxxx wrote: >> From: Ajay Singh <ajay.kathat@xxxxxxxxxxxxx> >> >> This file describes the binding details to connect wilc1000 device. It's >> moved from staging to 'Documentation/devicetree/bindings/net/wireless' >> path. >> >> Signed-off-by: Ajay Singh <ajay.kathat@xxxxxxxxxxxxx> >> --- >> .../net/wireless/microchip,wilc1000.yaml | 72 +++++++++++++++++++ >> 1 file changed, 72 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml >> >> diff --git a/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml >> new file mode 100644 >> index 000000000000..bc6cc5d3f347 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml >> @@ -0,0 +1,72 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/wireless/microchip,wilc1000.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Microchip WILC wireless devicetree bindings >> + >> +maintainers: >> + - Adham Abozaeid <adham.abozaeid@xxxxxxxxxxxxx> >> + - Ajay Singh <ajay.kathat@xxxxxxxxxxxxx> >> + >> +description: >> + The wilc1000 chips can be connected via SPI or SDIO. This document >> + describes the binding to connect wilc devices. >> + >> +properties: >> + compatible: >> + const: microchip,wilc1000 >> + >> + spi-max-frequency: true >> + >> + interrupts: >> + maxItems: 1 >> + >> + clocks: >> + description: phandle to the clock connected on rtc clock line. >> + maxItems: 1 >> + >> + clock-names: >> + const: rtc >> + >> +required: >> + - compatible >> + - interrupts >> + >> +examples: >> + - | >> + spi1: spi@fc018000 { > > spi { > >> + #address-cells = <1>; >> + #size-cells = <0>; >> + cs-gpios = <&pioB 21 0>; > > Drop this. Not relevant to the example. Ok. > >> + wifi@0 { >> + compatible = "microchip,wilc1000"; >> + spi-max-frequency = <48000000>; >> + reg = <0>; >> + interrupt-parent = <&pioC>; >> + interrupts = <27 0>; >> + clocks = <&pck1>; >> + clock-names = "rtc"; >> + }; >> + }; >> + >> + - | >> + mmc1: mmc@fc000000 { > > Drop the label. Either drop the unit address or add a 'reg' property to > match. Ok. I will drop the label and unit address in this. Regards, Ajay
