On Mon, Mar 23, 2020 at 12:47 AM Saravanan Sekar <sravanhome@xxxxxxxxx> wrote:
>
> Add support for 8-bit resolution ADC readings for input power
> supply and battery charging measurement. Provides voltage, current
> readings to mp2629 power supply driver.
...
> +#include <linux/platform_device.h>
> +#include <linux/of_device.h>
Don't see users of it.
> +#include <linux/module.h>
> +#include <linux/mutex.h>
> +#include <linux/regulator/consumer.h>
> +#include <linux/sysfs.h>
Any users?
> +#include <linux/regmap.h>
Perhaps ordered?
> +#include <linux/iio/iio.h>
> +#include <linux/iio/machine.h>
> +#include <linux/iio/driver.h>
+ blank line?
> +#include <linux/mfd/mp2629.h>
...
> +static int mp2629_read_raw(struct iio_dev *indio_dev,
> + struct iio_chan_spec const *chan,
> + int *val, int *val2, long mask)
> +{
> + struct mp2629_adc *info = iio_priv(indio_dev);
> + unsigned int rval;
> + int ret;
> +
> + switch (mask) {
> + case IIO_CHAN_INFO_RAW:
> + ret = regmap_read(info->regmap, chan->address, &rval);
> + if (ret < 0)
> + return ret;
> +
> + if (chan->address == MP2629_INPUT_VOLT)
> + rval &= 0x7f;
GENMASK() ?
> + *val = rval;
> + return IIO_VAL_INT;
> + return 0;
> +}
...
> + void **pdata = pdev->dev.platform_data;
Same Qs as per other patch.
...
> + indio_dev->dev.of_node = pdev->dev.of_node;
Jonathan, doesn't IIO core do this for all?
--
With Best Regards,
Andy Shevchenko
