Rob, On 20/03/2020 2.21, Rob Herring wrote: > On Thu, 19 Mar 2020 11:28:14 +0200, Peter Ujfalusi wrote: >> The audio support on the Common Processor Board board is using >> pcm3168a codec connected to McASP10 serializers in parallel setup. >> >> The Infotainment board plugs into the Common Processor Board, the support >> of the extension board is extending the CPB audio support by adding >> the two codecs on the expansion board. >> >> The audio support on the Infotainment Expansion Board consists of McASP0 >> connected to two pcm3168a codecs with dedicated set of serializers to each. >> The SCKI for pcm3168a is sourced from j721e AUDIO_REFCLK0 pin. >> >> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx> >> --- >> .../bindings/sound/ti,j721e-cpb-audio.yaml | 93 +++++++++++ >> .../sound/ti,j721e-cpb-ivi-audio.yaml | 145 ++++++++++++++++++ >> 2 files changed, 238 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/ti,j721e-cpb-audio.yaml >> create mode 100644 Documentation/devicetree/bindings/sound/ti,j721e-cpb-ivi-audio.yaml >> > > My bot found errors running 'make dt_binding_check' on your patch: > > Documentation/devicetree/bindings/sound/ti,j721e-cpb-ivi-audio.yaml: $id: relative path/filename doesn't match actual path or filename > expected: http://devicetree.org/schemas/sound/ti,j721e-cpb-ivi-audio.yaml# > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/ti,j721e-cpb-audio.yaml: duplicate '$id' value 'http://devicetree.org/schemas/sound/ti,j721e-cpb-audio.yaml#' > Error: Documentation/devicetree/bindings/sound/ti,j721e-cpb-ivi-audio.example.dts:21.23-24 syntax error > FATAL ERROR: Unable to parse input tree > scripts/Makefile.lib:311: recipe for target 'Documentation/devicetree/bindings/sound/ti,j721e-cpb-ivi-audio.example.dt.yaml' failed > make[1]: *** [Documentation/devicetree/bindings/sound/ti,j721e-cpb-ivi-audio.example.dt.yaml] Error 1 > make[1]: *** Waiting for unfinished jobs.... > Makefile:1262: recipe for target 'dt_binding_check' failed > make: *** [dt_binding_check] Error 2 I made copy-paste error (two) when creating the cpb-ivi yaml and forgot to re-run the dt_binding_check Fixed up and verified that the build is clean now. > See https://patchwork.ozlabs.org/patch/1258054 > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure dt-schema is up to date: > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > Please check and re-submit. > - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki