On 19-03-20, 17:03, Rajendra Nayak wrote: > sure, I understand there is a dependency, however refusing to review the approach > (to add multiple OPPS tables per device) that this series is taking because of an outstanding > question which, if I read it right is "We can not add multiple OPP tables for a single device right now" > seems odd. > > Its fine if you are not happy with the approach taken here and you can propose something else, > but it looks inevitable that we would need something like this to be supported (multiple OPP tables per device) > and hence the request to review the patches. I understand the frustration you have right now, but honestly most of the delay is not from my part. I normally try to be very quick in giving reviews or even accepting material for next cycle. Still, I am part of the chain which has blocked this series and I am really sorry for that. Coming back to reviews. I never liked the idea of keeping separate OPP tables just for the relation that a peripheral share with the interconnect, i.e. the b/w tables getting discussed right now. And I am not at all sure if such tables should be added as device tables anyway, it was present in cover letter of Saravana for sometime but not in the real patches and so I missed it until the time Sibi asked me something on IRC. To be clear, I don't think we will allow multiple active OPP tables for a device for now, unless we have a very good reason to do that. It just doesn't make sense to me to have one table for keeping frequency/voltage thing, and another set of tables for b/w requirements from interconnect. So, the changes proposed by this patchset even doesn't matter as I am not agreeing on the binding itself. And we need a binding change for that, which Saravana never sent, i.e. to have multiple active tables for a device. Yes, we need a solution for this and a quick one. I am fine to discuss this all on a hangout session (anyway, everyone is working from home now anyways) anytime next week with the interested parties. I think /me and Vincent can join it. -- viresh
