On Tue, Mar 17, 2020 at 02:32:25PM +0200, Oleksandr Suvorov wrote: > The polarity enum definition PWM_POLARITY_INVERSED is misspelled. > Rename it to PWM_POLARITY_INVERTED. It isn't misspelled. "inversed" is a synonym for "inverted". Both spellings are correct. And as you noted in the cover letter, there's a conflict between the macro defined in dt-bindings/pwm/pwm.txt. If they end up being included in the wrong order you'll get a compile error. The enum was named this way on purpose to make it separate from the definition for the DT bindings. Note that DT bindings are an ABI and can never change, whereas the enum pwm_polarity is part of a Linux internal API and doesn't have the same restrictions as an ABI. As far as I'm concerned this is completely unnecessary churn that's potentially going to come back and bite us, so I see no reason to accept this. Thierry
Attachment:
signature.asc
Description: PGP signature
