Hi Adam,
On Tue, Mar 10, 2020 at 10:01 PM Adam Ford <aford173@xxxxxxxxx> wrote:
> +&ecspi2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_espi2>;
> + cs-gpios = <&gpio5 9 0>;
You could use GPIO_ACTIVE_HIGH instead of hardcoded 0.
> + status = "okay";
> +
> + at25@0 {
Node names should be generic:
eeprom@0
> + compatible = "atmel,at25";
Documentation/devicetree/bindings/eeprom/at25.txt states:
"- compatible : Should be "<vendor>,<type>", and generic value "atmel,at25".
Example "<vendor>,<type>" values:
"microchip,25lc040"
"st,m95m02"
"st,m95256"
> +&i2c4 {
> +
Unneeded blank line.
> diff --git a/arch/arm64/boot/dts/freescale/beacon-imx8mm-kit.dts b/arch/arm64/boot/dts/freescale/beacon-imx8mm-kit.dts
> new file mode 100644
> index 000000000000..417b15d345d5
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/beacon-imx8mm-kit.dts
> @@ -0,0 +1,19 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright 2020 Compass Electronics Group, LLC
> + */
> +
> +/dts-v1/;
> +
> +#include "imx8mm.dtsi"
> +#include "beacon-imx8mm-som.dtsi"
> +#include "beacon-imx8mm-baseboard.dtsi"
The naming convention we use is to start the dts names with the i.MX
SoC name, so:
imx8mm-beacon-som.dtsi
imx8mm-beacon-baseboard.dtsi
> +/ {
> + model = "Beacon EmbeddedWorks i.MX8M Mini Development Kit";
> + compatible = "fsl,imx8mm";
You should add an Entry for Beacon in
Documentation/devicetree/bindings/vendor-prefixes.yaml on a separate
patch.
and then:
compatible = "beacon,imx8mm-beacon-kit", "fsl,imx8mm"
Also, please add an entry for this board in
Documentation/devicetree/bindings/arm/fsl.yaml
> +&i2c3 {
> + clock-frequency = <400000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_i2c3>;
> + status = "okay";
> +
> + eeprom@50 {
> + compatible = "atmel,24c64";
Same comment about the compatible.
> +&iomuxc {
> +
Unneeded blank line.
> + pinctrl_fec1: fec1grp {
