Hi Fabio,
On Sat, 2020-02-29 at 10:07 -0300, Fabio Estevam wrote:
> > + fan: gpio_fan {
>
> Underscores are not recommended in property names. Please use
> "gpio-fan" instead.
Sure. I'll fix it.
> > + compatible = "gpio-fan";
> > + gpio-fan,speed-map = <0 0 8600 1>;
> > + gpios = <&gpio3 5 GPIO_ACTIVE_HIGH>;
>
> Please add an entry for the pinctrl description of this GPIO.
> It worked because GPIO is the default functionality of the pin after
> POR, but we should better not rely on it (bootloaders may change it)
> and explicitly it in the device tree.
Thanks. I'll do that.
> > +
> > +&tmu {
>
> Please keep the nodes in alphabetical order.
>
>
> > + throttle-cfgs {
> > + throttle_devfreq: devfreq {
> > + throttle,max_state = <2>;
>
> I don't see this property documented anywhere. Should it be removed?
Yes, I'll remove it.
BR,
Vitor
