Hi Vitor, Thanks for your patch. On Sat, Feb 29, 2020 at 7:43 AM Vitor Massaru Iha <vitor@xxxxxxxxxxx> wrote: > > It was based on Google Source Code for Coral Edge TPU Mendel release: > https://coral.googlesource.com/linux-imx/ > > It was tested on Coral Dev Board using this command: > sudo stress --cpu 4 --timeout 3600 > > Signed-off-by: Vitor Massaru Iha <vitor@xxxxxxxxxxx> > --- > .../boot/dts/freescale/imx8mq-phanbell.dts | 78 +++++++++++++++++++ > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 2 +- > 2 files changed, 79 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-phanbell.dts b/arch/arm64/boot/dts/freescale/imx8mq-phanbell.dts > index 3f2a489a4ad8..fb9f208d1e41 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-phanbell.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mq-phanbell.dts > @@ -35,6 +35,14 @@ > gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>; > enable-active-high; > }; > + > + fan: gpio_fan { Underscores are not recommended in property names. Please use "gpio-fan" instead. > + compatible = "gpio-fan"; > + gpio-fan,speed-map = <0 0 8600 1>; > + gpios = <&gpio3 5 GPIO_ACTIVE_HIGH>; Please add an entry for the pinctrl description of this GPIO. It worked because GPIO is the default functionality of the pin after POR, but we should better not rely on it (bootloaders may change it) and explicitly it in the device tree. > + #cooling-cells = <2>; > + status = "okay"; > + }; > }; > > &A53_0 { > @@ -374,3 +382,73 @@ > >; > }; > }; > + > +&tmu { Please keep the nodes in alphabetical order. > + throttle-cfgs { > + throttle_devfreq: devfreq { > + throttle,max_state = <2>; I don't see this property documented anywhere. Should it be removed? Thanks
