Hi Paul, > Am 29.02.2020 um 17:09 schrieb Paul Cercueil <paul@xxxxxxxxxxxxxxx>: > > Hi Nikolaus, > > > Le ven., févr. 28, 2020 at 19:02, H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> a écrit : >> There is a ACT8600 on the CI20 board and the bindings of the >> ACT8865 driver have changed without updating the CI20 device >> tree. Therefore the PMU can not be probed successfully and >> is running in power-on reset state. >> Fix DT to match the latest act8865-regulator bindings. >> Fixes: 73f2b940474d ("MIPS: CI20: DTS: Add I2C nodes") >> Cc: stable@xxxxxxxxxxxxxxx >> Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> >> --- >> arch/mips/boot/dts/ingenic/ci20.dts | 48 ++++++++++++++++++++--------- >> 1 file changed, 33 insertions(+), 15 deletions(-) >> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts b/arch/mips/boot/dts/ingenic/ci20.dts >> index 59c104289ece..44741e927d2b 100644 >> --- a/arch/mips/boot/dts/ingenic/ci20.dts >> +++ b/arch/mips/boot/dts/ingenic/ci20.dts >> @@ -4,6 +4,8 @@ >> #include "jz4780.dtsi" >> #include <dt-bindings/clock/ingenic,tcu.h> >> #include <dt-bindings/gpio/gpio.h> >> +#include <dt-bindings/interrupt-controller/irq.h> > > This include should be in patch 3/5 where it's first used. Yes. That is much better. > > With that fixed: > Reviewed-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx> > > for the whole series. What is easier: that you fix it during applying somewhere or should I send a v5? BR, Nikolaus