On Monday 12 May 2014 11:44:45 Shaik Ameer Basha wrote: > This is the subset of previous v12 series and includes only the fixes and > enhancements, leaving out the private DT bindings as discussed in the below thread. > -- http://www.gossamer-threads.com/lists/linux/kernel/1918178 > > This patch series includes, > 1] fixes for exynos-iommu driver build break > 2] includes several bug fixes and enhancements for the exynos-iommu driver > 3] code to handle multiple exynos sysmmu versions > 4] adding support for device tree > Documentation/devicetree/bindings/iommu/samsung,sysmmu.txt The patches look good to me, but please add a note into the samsung,sysmmu.txt file explaining that the binding is incomplete and that it's possible to change in incompatible ways when we add support for attaching devices to the IOMMU through the generic IOMMU binding. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html