On Mon, 10 Feb 2020 08:56:28 +0100
Maxime Ripard <maxime@xxxxxxxxxx> wrote:
> > +// SPDX-License-Identifier: GPL-2.0-or-later
>
> Using a double license would be great, otherwise other projects
> licensed under something else than the GPL might not be able to use
> it.
I don't get it, why GPL v2 is not adequate here...
> > + leds {
> > + compatible = "gpio-leds";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&led_pins_lamobo_r1>;
>
> You don't need the pinctrl nodes at all for GPIOs
I did not agree on that:
The pincontrol configuration depend on the bootloader if you omit the
configuration here. That may sufficient in most cases, but can cause
unexpected behaviour after updating the bootloader or using kexec.
The A20 datasheet mentioned:
"For various system configurations, these ports can be easily
configured by software. All these ports can be configured as GPIO if
multiplexed functions not used. 32 external PIO interrupt sources are
supported and interrupt mode can be configured by software."
I cannot simply check, if the pin was used otherwise.
Therefore adding a pincontrl for a defined state of a pin seems
reasonable.
Regards
Benedikt Spranger
Attachment:
pgpr8196IBnyh.pgp
Description: Digitale Signatur von OpenPGP
