Hi Rob,
On 27/01/2020 20.49, Rob Herring wrote:
> On Mon, Jan 27, 2020 at 12:56:33PM +0200, Peter Ujfalusi wrote:
>> TC358768/TC358778 is a Parallel RGB to MIPI DSI bridge.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx>
>> ---
>> .../display/bridge/toshiba,tc358768.yaml | 158 ++++++++++++++++++
>> 1 file changed, 158 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
>> new file mode 100644
>> index 000000000000..8dd8cca39a77
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
>> +examples:
>> + - |
>> + i2c1 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + dsi_bridge: tc358768@0e {
>
> Generic node names and no leading 0s:
>
> dsi-bridge@e
Right, I'll correct it.
>> + compatible = "toshiba,tc358768";
>> + reg = <0x0e>;
>> +
>> + clocks = <&tc358768_refclk>;
>> + clock-names = "refclk";
>> +
>> + /* GPIO line is inverted before going to the bridge */
>> + reset-gpios = <&pcf_display_board 0 1 /* GPIO_ACTIVE_LOW */>;
>
> You just need to add the include for the define to work.
You are right, it compiles fine with the include added.
Thank you,
- Péter
>> +
>> + vddc-supply = <&v1_2d>;
>> + vddmipi-supply = <&v1_2d>;
>> + vddio-supply = <&v3_3d>;
>> +
>> + dsi_bridge_ports: ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + port@0 {
>> + reg = <0>;
>> + rgb_in: endpoint {
>> + remote-endpoint = <&dpi_out>;
>> + data-lines = <24>;
>> + };
>> + };
>> +
>> + port@1 {
>> + reg = <1>;
>> + dsi_out: endpoint {
>> + remote-endpoint = <&lcd_in>;
>> + };
>> + };
>> + };
>> + };
>> + };
>> +
>> --
>> Peter
>>
>> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
>> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>>
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
