On Sat, Jan 18, 2020 at 10:23:15AM +0100, Charles-Antoine Couret wrote: > Document the bindings for the tas5756m driver. > --- > .../devicetree/bindings/sound/tas5756m.txt | 25 +++++++++++++++++++ > 1 file changed, 25 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/tas5756m.txt Can you make this a DT schema. > > diff --git a/Documentation/devicetree/bindings/sound/tas5756m.txt b/Documentation/devicetree/bindings/sound/tas5756m.txt > new file mode 100644 > index 000000000000..293eaf20d008 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/tas5756m.txt > @@ -0,0 +1,25 @@ > +TAS5756M audio CODEC > + > +Required properties: > + > + - compatible: should be one of the following: > + - "ti,tas5756m" > + - "ti,tas5754m" > + - reg: the I2C address of the device for I2C. > + > +Optional properties: > + > + - mute-gpio : GPIO wired to the mute pin. mute-gpios is the preferred form. > + - hybridflow : an integer between 1 and 9 to select the HybridFlow program. > + if not supplied default DSP program is used. Needs a vendor prefix. Is this something fixed for the life of a board or something users would want to change at runtime? > + > +Example: > + > + tas5756m: tas5756m@4c { > + compatible = "ti,tas5756m"; > + reg = <0x4c>; > + #sound-dai-cells = <0>; Not documented. > + > + hybridflow = <6>; > + mute-gpio = <&gpio1 11 GPIO_ACTIVE_LOW>; > + }; > -- > 2.24.1 >