On Fri, 17 Jan 2020 15:53:26 -0800, Douglas Anderson wrote: > On many arm64 qcom device trees, running `make dtbs_check` yells: > > timer@17c20000: #size-cells:0:0: 1 was expected > > It appears that someone was trying to assert the fact that sub-nodes > describing frames would never have a size that's more than 32-bits > big. That does indeed appear to be true for all cases I could find. > > Currently many arm64 qcom device tree files have a #address-cells and > about in commit bede7d2dc8f3 ("arm64: dts: qcom: sdm845: Increase > address and size cells for soc"). That means the only way we can > shrink them down is to use a non-empty ranges. > > Since forever it has said in "writing-bindings.txt" to "DO use > non-empty 'ranges' to limit the size of child buses/devices". I guess > we should start listening to it. > > I believe (but am not certain) that this also means that we should use > "ranges" to simplify the "reg" of our sub devices by specifying an > offset. Let's update the example in the bindings to make this > obvious. > > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > --- > See: > https://lore.kernel.org/r/20191212113540.7.Ia9bd3fca24ad34a5faaf1c3e58095c74b38abca1@changeid > > ...for the patch that sparked this change. > > Changes in v3: > - Fixed my typo frame@f0003000 => frame@2000 > > Changes in v2: > - Fixed my typo 0xf0000000 => 0xf0001000 > > .../bindings/timer/arm,arch_timer_mmio.yaml | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > Applied, thanks. Rob