Re: [PATCH v3 4/7] drm/panfrost: Add support for multiple regulators

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 21/01/2020 04:37, Nicolas Boichat wrote:
On Tue, Jan 14, 2020 at 10:16 PM Mark Brown <broonie@xxxxxxxxxx> wrote:

On Tue, Jan 14, 2020 at 03:15:59PM +0800, Nicolas Boichat wrote:

  - I couldn't find a way to detect the number of regulators in the
    device tree, if we wanted to refuse to probe the device if there
    are too many regulators, which might be required for safety, see
    the thread on v2 [1].

You'd need to enumerate all the properties of the device and look
for things matching *-supply.

I see ,-) I was hoping for something slightly cleaner, or maybe an
existing function in the core.

Steven: How strongly do you feel about this? If so I can add that
check in the next revision.

I'm not that strongly bothered about it - my only worry is that there may be hardware out there that might be broken by not activating a regulator. But I don't know how common this multi-regulator design is in practise.

Thanks,

Steve

Also, just a heads-up, I'm out for the next 2 weeks, I'll send v4 after that.


Reviewed-by: Mark Brown <broonie@xxxxxxxxxx>
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux