Re: [PATCH 1/3] dt-bindings: net: can: m_can: Add Documentation for stb-gpios

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Faiz

On 1/22/20 2:03 AM, Faiz Abbas wrote:
The CAN transceiver on some boards has an STB pin which is
used to control its standby mode. Add an optional property
stb-gpios to toggle the same.

Signed-off-by: Faiz Abbas <faiz_abbas@xxxxxx>
Signed-off-by: Sekhar Nori <nsekhar@xxxxxx>
---
  Documentation/devicetree/bindings/net/can/m_can.txt | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/can/m_can.txt b/Documentation/devicetree/bindings/net/can/m_can.txt
index ed614383af9c..cc8ba3f7a2aa 100644
--- a/Documentation/devicetree/bindings/net/can/m_can.txt
+++ b/Documentation/devicetree/bindings/net/can/m_can.txt
@@ -48,6 +48,8 @@ Optional Subnode:
  			  that can be used for CAN/CAN-FD modes. See
  			  Documentation/devicetree/bindings/net/can/can-transceiver.txt
  			  for details.
+stb-gpios		: gpio node to toggle the STB (standby) signal on the transceiver
+

The m_can.txt is for the m_can framework.  If this is specific to the platform then it really does not belong here.

If the platform has specific nodes then maybe we need a m_can_platform.txt binding for specific platform nodes.  But I leave that decision to Rob.

Also I prefer you spell out standby like the gpios are spelled out in the tcan binding.

Dan


  Example:
  SoC dtsi:
  m_can1: can@20e8000 {



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux