Hi Rob/Kishon, On Wed, Jan 8, 2020 at 4:22 PM Lad Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > > This patch adds the bindings for the R-Car PCIe endpoint driver. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > --- > .../devicetree/bindings/pci/rcar-pci-ep.yaml | 76 +++++++++++++++++++ > 1 file changed, 76 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml > > diff --git a/Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml b/Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml > new file mode 100644 > index 000000000000..99c2a1174463 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml > @@ -0,0 +1,76 @@ > +# SPDX-License-Identifier: GPL-2.0 > +# Copyright (C) 2020 Renesas Electronics Europe GmbH - https://www.renesas.com/eu/en/ > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pci/rcar-pcie-ep.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas R-Car PCIe Endpoint > + > +maintainers: > + - Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > + > +properties: > + compatible: > + items: > + - const: renesas,r8a774c0-pcie-ep > + - const: renesas,rcar-gen3-pcie-ep > + > + reg: > + maxItems: 5 > + > + reg-names: > + items: > + - const: apb-base > + - const: memory0 > + - const: memory1 > + - const: memory2 > + - const: memory3 > + > + power-domains: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + - const: pcie > + > + max-functions: > + minimum: 1 > + maximum: 6 > + > +required: > + - compatible > + - reg > + - reg-names > + - resets > + - power-domains > + - clocks > + - clock-names > + - max-functions > + apart from dt_binding_check error are we OK with dt bindings ? Cheers, --Prabhakar > +examples: > + - | > + #include <dt-bindings/clock/r8a774c0-cpg-mssr.h> > + #include <dt-bindings/power/r8a774c0-sysc.h> > + > + pcie0_ep: pcie-ep@fe000000 { > + compatible = "renesas,r8a774c0-pcie-ep", > + "renesas,rcar-gen3-pcie-ep"; > + reg = <0 0xfe000000 0 0x80000>, > + <0x0 0xfe100000 0 0x100000>, > + <0x0 0xfe200000 0 0x200000>, > + <0x0 0x30000000 0 0x8000000>, > + <0x0 0x38000000 0 0x8000000>; > + reg-names = "apb-base", "memory0", "memory1", "memory2", "memory3"; > + resets = <&cpg 319>; > + power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>; > + clocks = <&cpg CPG_MOD 319>; > + clock-names = "pcie"; > + max-functions = /bits/ 8 <1>; > + }; > -- > 2.20.1 >