On Mon, Jan 20, 2020 at 11:10 PM Kishon Vijay Abraham I <kishon@xxxxxx> wrote: > > Hi Rob, > > On 15/01/20 7:17 AM, Rob Herring wrote: > > On Wed, Jan 08, 2020 at 01:18:27PM +0200, Roger Quadros wrote: > >> From: Kishon Vijay Abraham I <kishon@xxxxxx> > >> > >> Add serdes_ln_ctrl node used for selecting SERDES lane mux. > >> > >> Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx> > >> Signed-off-by: Sekhar Nori <nsekhar@xxxxxx> > >> Signed-off-by: Roger Quadros <rogerq@xxxxxx> > >> --- > >> arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 26 +++++++++++ > >> include/dt-bindings/mux/mux-j721e-wiz.h | 53 +++++++++++++++++++++++ > >> 2 files changed, 79 insertions(+) > >> create mode 100644 include/dt-bindings/mux/mux-j721e-wiz.h > >> > >> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > >> index 24cb78db28e4..6741c1e67f50 100644 > >> --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > >> +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > >> @@ -5,6 +5,8 @@ > >> * Copyright (C) 2016-2019 Texas Instruments Incorporated - http://www.ti.com/ > >> */ > >> #include <dt-bindings/phy/phy.h> > >> +#include <dt-bindings/mux/mux.h> > >> +#include <dt-bindings/mux/mux-j721e-wiz.h> > >> > >> &cbass_main { > >> msmc_ram: sram@70000000 { > >> @@ -19,6 +21,30 @@ > >> }; > >> }; > >> > >> + scm_conf: scm_conf@100000 { > > > > Don't use '_' in node names. > > Okay. > > > >> + compatible = "syscon", "simple-mfd"; > > > > Needs a specific compatible especially since the child node doesn't have > > one. > > Child node has "mmio-mux" as compatible no? Are you referring to > something else here? I'm referring to exactly what I quoted, but that's also a generic compatible, so you'd never be able to match any of this block to a specific driver or handle any quirks. Rob
