Hi, On 1/21/20 4:26 PM, Dafna Hirschfeld wrote: > > > On 21.01.20 16:11, Johan Jonker wrote: >> Hi Dafna, >> >> >>> >>> >>> On 21.01.20 15:03, Rob Herring wrote: >>>> On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld >>>> <dafna.hirschfeld@xxxxxxxxxxxxx> wrote: >>>>> >>>>> convert the binding file rockchip-drm.txt to yaml format. >>>>> This was tested and verified with: >>>>> make dt_binding_check >>>>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml >>>>> >>>> >>>> Also, make sure just 'make dt_binding_check' passes as that checks the >>>> example against all schemas. >>> >>> But this also checks the other schemas in general, and when running it, >>> it fails because of bugs in other schemas. >> >> >>> For example with arm=ARM I get: >> >> Use: >> >> # enable Rockchip arm in menuconfig >> make ARCH=arm menuconfig >> >> make ARCH=arm dt_binding_check >> DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml >> >> >> and not: >> arm=ARM >> > yes, sorry, this is what I did. When running with the DT_SCHEMA_FILES > set then it passes both on ARM and ARM64 > but when this variable is not set I get the above error. # for Intel use: make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml # for Rockchip use: make ARCH=arm dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml Also change: example: Reduce some spaces here. Also remove "|" from description. See: description: | A more detailed multi-line description of the binding. Details about the hardware device and any links to datasheets can go here. Literal blocks are marked with the '|' at the beginning. The end is marked by indentation less than the first line of the literal block. Lines also cannot begin with a tab character. > > Dafna > >> >>> >>> DTC >>> Documentation/devicetree/bindings/clock/qcom,gcc.example.dt.yaml >>> Error: >>> Documentation/devicetree/bindings/clock/qcom,gcc.example.dts:111.28-29 >>> syntax error >>> FATAL ERROR: Unable to parse input tree >>> >>> Dafna >>> >>>> >>>>> make dtbs_check >>>>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml >>>>> >>>>> >>
