On 09/05/2014 10:18, Hans de Goede wrote: > Hi, > > On 05/09/2014 10:08 AM, Lee Jones wrote: >>>>>>> +static struct platform_driver sun6i_prcm_driver = { >>>>>>> + .driver = { >>>>>>> + .name = "sun6i-prcm", >>>>>>> + .owner = THIS_MODULE, >>>>>>> + .of_match_table = sun6i_prcm_dt_ids, >>>>>>> + }, >>>>>>> + .probe = sun6i_prcm_probe, >>>>>> You need a .remove() call-back. >>>>> This driver cannot be compiled as module (see the Kconfig definition) >>>>> and the devices are not hotpluggable, as a result a probed device will >>>>> never be removed. >>>>> >>>>> Do you still want me to implement the remove function ? >>>> .remove() also be run on shut down. >>> That is not true, if your device needs to do anything special at shutdown >>> you need to add a shutdown callback. Devices are kept as is (not torn down) >>> on shutdown. >> Ah okay, I'll bow to your knowledge. So there's no reason for this >> driver to ever call mfd_remove_devices() then? > No, this is an integral part of the SOC, which never gets removed in any way. Lee, I'm about to send a 3rd version of this series, is it okay for you if I leave the remove function unimplemented ? > > Regards, > > Hans -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html