Hi Tomasz, On 04/26/2014 08:38 PM, Tomasz Figa wrote: > On 26.04.2014 02:51, Tomasz Figa wrote: >> Hi Chanwoo, >> >> On 25.04.2014 03:16, Chanwoo Choi wrote: >>> From: Tomasz Figa <t.figa@xxxxxxxxxxx> >>> >>> This patch add new exynos3250.dtsi to support Exynos3250 SoC based on >>> Cortex-A7 >>> dual core and includes following dt nodes: >>> >>> - GIC interrupt controller >>> - Pinctrl to control GPIOs >>> - Clock controller >>> - CPU information (Cortex-A7 dual core) >>> - UART to support serial port >>> - MCT (Multi Core Timer) >>> - ADC (Analog Digital Converter) >>> - I2C/SPI bus >>> - Power domain >>> - PMU (Performance Monitoring Unit) >>> - MSHC (Mobile Storage Host Controller) >>> - PWM (Pluse Width Modulation) >>> - AMBA bus >>> >>> Signed-off-by: Tomasz Figa <t.figa@xxxxxxxxxxx> >>> Signed-off-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx> >>> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> >>> Signed-off-by: Inki Dae <inki.dae@xxxxxxxxxxx> >>> Signed-off-by: Hyunhee Kim <hyunhee.kim@xxxxxxxxxxx> >>> Signed-off-by: Jaehoon Chung <jh80.chung@xxxxxxxxxxx> >>> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> >>> Cc: Ben Dooks <ben-linux@xxxxxxxxx> >>> Cc: Kukjin Kim <kgene.kim@xxxxxxxxxxx> >>> Cc: Rob Herring <robh+dt@xxxxxxxxxx> >>> Cc: Pawel Moll <pawel.moll@xxxxxxx> >>> Cc: Mark Rutland <mark.rutland@xxxxxxx> >>> Cc: Ian Campbell <ijc+devicetree@xxxxxxxxxxxxxx> >>> Cc: Kumar Gala <galak@xxxxxxxxxxxxxx> >>> Cc: Russell King <linux@xxxxxxxxxxxxxxxx> >>> Cc: devicetree@xxxxxxxxxxxxxxx >>> --- >>> arch/arm/boot/dts/exynos3250-pinctrl.dtsi | 477 +++++++++++++++ >>> arch/arm/boot/dts/exynos3250.dtsi | 405 +++++++++++++ >>> arch/arm/boot/dts/exynos4212-tizenw.dts | 926 >>> ++++++++++++++++++++++++++++++ >>> 3 files changed, 1808 insertions(+) >>> create mode 100644 arch/arm/boot/dts/exynos3250-pinctrl.dtsi >>> create mode 100644 arch/arm/boot/dts/exynos3250.dtsi >>> create mode 100644 arch/arm/boot/dts/exynos4212-tizenw.dts >>> >>> diff --git a/arch/arm/boot/dts/exynos3250-pinctrl.dtsi >>> b/arch/arm/boot/dts/exynos3250-pinctrl.dtsi >>> new file mode 100644 >>> index 0000000..976490b >>> --- /dev/null >>> +++ b/arch/arm/boot/dts/exynos3250-pinctrl.dtsi >>> @@ -0,0 +1,477 @@ >>> +/* >>> + * Samsung's Exynos3250 SoCs pin-mux and pin-config device tree source >>> + * >>> + * Copyright (c) 2014 Samsung Electronics Co., Ltd. >>> + * http://www.samsung.com >>> + * >>> + * Samsung's Exynos3250 SoCs pin-mux and pin-config optiosn are >>> listed as device >>> + * tree nodes are listed in this file. >>> + * >>> + * This program is free software; you can redistribute it and/or modify >>> + * it under the terms of the GNU General Public License version 2 as >>> + * published by the Free Software Foundation. >>> +*/ >>> + >>> +/ { >>> + pinctrl@11400000 { >> >> Could you use references instead of re-specifying the whole tree >> hierarchy in every file a node is used? >> >> Instead of >> >> / { >> pinctrl@11400000 { >> >> }; >> }; >> >> one may simply use >> >> &pinctrl_0 { >> >> }; >> >> You might just need to change the location of #include >> "exynos3250-pinctrl.dtsi" from top of exynos3250.dtsi to bottom of it. > > Oh, well, you also should move all nodes of on-SoC devices under a simple-bus node called soc. You can see the patch adding dts file for Exynos5260 for an example [1]. > > [1] http://thread.gmane.org/gmane.linux.kernel.samsung-soc/29360/focus=29361 OK, I'll move nodes dependent on SoC under 'soc' dt node as example patch[1] except for 'amba-bus' dt node. Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
