On Tue, Jan 14, 2020 at 03:22:58PM +0800, Shawn Lin wrote:
> From: Simon Xue <xxm@xxxxxxxxxxxxxx>
>
> Signed-off-by: Simon Xue <xxm@xxxxxxxxxxxxxx>
> Signed-off-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>
> ---
>
> .../devicetree/bindings/pci/rockchip-dw-pcie.yaml | 132 +++++++++++++++++++++
> 1 file changed, 132 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml:
properties:rockchip,usbpciegrf: {'items': [{'description': 'The grf for
COMBPHY configuration and state registers.'}]} is not valid under any of
the given schemas (Possible causes of the failure):
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml:
properties:rockchip,usbpciegrf: 'description' is a required property
>
> diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
> new file mode 100644
> index 0000000..c5205f6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
> @@ -0,0 +1,132 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pci/rockchip-dw-pcie.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: DesignWare based PCIe RC controller on Rockchip SoCs
> +
> +maintainers:
> + - Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>
> + - Simon Xue <xxm@xxxxxxxxxxxxxx>
indent 2 spaces.
> +
You need to reference pci-bus.yaml.
> +properties:
> + compatible:
> + enum:
> + - rockchip,rk1808-pcie
> + - snps,dw-pcie
This means the compatible is one of these 2 strings.
It's also going to be a problem because it will match on all DTs with
'snps,dw-pcie'. Look at some of the 'arm,primecell' schema for how to
avoid that with 'select'.
> +
> + reg:
> + maxItems: 2
> +
> + clocks:
> + items:
> + - description: High speed clock for PCIe
> + - description: Low speed clock for PCIe
> + - description: AHB clock for PCIe
> + - description: APB clock for PCIe
> + - description: Auxiliary clock for PCIe
> +
> + clock-names:
> + items:
> + - const: hsclk
> + - const: lsclk
> + - const: aclk
> + - const: pclk
> + - const: sclk-aux
> +
> + resets:
> + items:
> + - description: PCIe niu high reset line
> + - description: PCIe niu low reset line
> + - description: PCIe grf reset line
> + - description: PCIe control reset line
> + - description: PCIe control powerup reset line
> + - description: PCIe control master reset line
> + - description: PCIe control slave reset line
> + - description: PCIe control dbi reset line
> + - description: PCIe control button reset line
> + - description: PCIe control power engine reset line
> + - description: PCIe control core reset line
> + - description: PCIe control non-sticky reset line
> + - description: PCIe control sticky reset line
> + - description: PCIe control power reset line
> + - description: PCIe niu ahb reset line
> + - description: PCIe niu apb reset line
> +
> + reset-names:
> + items:
> + - const: niu-h
> + - const: niu-l
> + - const: grf-p
> + - const: ctl-p
> + - const: ctl-powerup
> + - const: ctl-mst-a
> + - const: ctl-slv-a
> + - const: ctl-dbi-a
> + - const: ctl-button
> + - const: ctl-pe
> + - const: ctl-core
> + - const: ctl-nsticky
> + - const: ctl-sticky
> + - const: ctl-pwr
> + - const: ctl-niu-a
> + - const: ctl-niu-p
> +
> + rockchip,usbpciegrf:
> + items:
> + - description: The grf for COMBPHY configuration and state registers.
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - msi-map
> + - num-lanes
> + - phys
> + - phy-names
> + - resets
> + - reset-names
> + - rockchip,usbpciegrf
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + usb_pcie_grf: syscon@fe040000 {
> + compatible = "rockchip,usb-pcie-grf", "syscon";
> + reg = <0x0 0xfe040000 0x0 0x1000>;
> + };
> +
> + pcie0: pcie@fc400000 {
> + compatible = "rockchip,rk1808-pcie", "snps,dw-pcie";
> + reg = <0x0 0xfc000000 0x0 0x400000>,
> + <0x0 0xfc400000 0x0 0x10000>;
> + clocks = <&cru HSCLK_PCIE>, <&cru LSCLK_PCIE>,
> + <&cru ACLK_PCIE>, <&cru PCLK_PCIE>,
> + <&cru SCLK_PCIE_AUX>;
> + clock-names = "hsclk", "lsclk",
> + "aclk", "pclk",
> + "sclk-aux";
> + msi-map = <0x0 &its 0x0 0x1000>;
> + num-lanes = <2>;
> + phys = <&combphy PHY_TYPE_PCIE>;
> + phy-names = "pcie-phy";
> + resets = <&cru SRST_PCIE_NIU_H>, <&cru SRST_PCIE_NIU_L>,
> + <&cru SRST_PCIEGRF_P>, <&cru SRST_PCIECTL_P>,
> + <&cru SRST_PCIECTL_POWERUP>, <&cru SRST_PCIECTL_MST_A>,
> + <&cru SRST_PCIECTL_SLV_A>, <&cru SRST_PCIECTL_DBI_A>,
> + <&cru SRST_PCIECTL_BUTTON>, <&cru SRST_PCIECTL_PE>,
> + <&cru SRST_PCIECTL_CORE>, <&cru SRST_PCIECTL_NSTICKY>,
> + <&cru SRST_PCIECTL_STICKY>, <&cru SRST_PCIECTL_PWR>,
> + <&cru SRST_PCIE_NIU_A>, <&cru SRST_PCIE_NIU_P>;
> + reset-names = "niu-h", "niu-l", "grf-p", "ctl-p",
> + "ctl-powerup", "ctl-mst-a", "ctl-slv-a",
> + "ctl-dbi-a", "ctl-button", "ctl-pe",
> + "ctl-core", "ctl-nsticky", "ctl-sticky",
> + "ctl-pwr", "ctl-niu-a", "ctl-niu-p";
> + rockchip,usbpciegrf = <&usb_pcie_grf>;
You are missing a number of common, required PCI properties.
> + };
> +
> +...
> --
> 1.9.1
>
>
>
