On 14.01.2020 13:17, Alexandre Belloni wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 14/01/2020 11:10:14+0000, Claudiu.Beznea@xxxxxxxxxxxxx wrote: >> >> >> On 14.01.2020 12:42, Alexandre Belloni wrote: >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >>> >>> On 14/01/2020 12:23:14+0200, Claudiu Beznea wrote: >>>> Remove chip whildcard and introduce the list of compatibles instead. >>>> >>>> Signed-off-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx> >>>> --- >>>> Documentation/devicetree/bindings/mfd/atmel-usart.txt | 7 +++---- >>>> 1 file changed, 3 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/mfd/atmel-usart.txt b/Documentation/devicetree/bindings/mfd/atmel-usart.txt >>>> index 699fd3c9ace8..778e8310606a 100644 >>>> --- a/Documentation/devicetree/bindings/mfd/atmel-usart.txt >>>> +++ b/Documentation/devicetree/bindings/mfd/atmel-usart.txt >>>> @@ -1,10 +1,9 @@ >>>> * Atmel Universal Synchronous Asynchronous Receiver/Transmitter (USART) >>>> >>>> Required properties for USART: >>>> -- compatible: Should be "atmel,<chip>-usart" or "atmel,<chip>-dbgu" >>>> - The compatible <chip> indicated will be the first SoC to support an >>>> - additional mode or an USART new feature. >>>> - For the dbgu UART, use "atmel,<chip>-dbgu", "atmel,<chip>-usart" >>>> +- compatible: Should be one of the following: >>>> + - "atmel,at91rm9200-dbgu", "atmel,at91rm9200-usart" >>>> + - "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart" >>> >>> All the uarts are not dbgus, so this need to be: >>> >>> - "atmel,at91rm9200-usart" >>> - "atmel,at91sam9260-usart" >>> - "atmel,at91rm9200-dbgu", "atmel,at91rm9200-usart" >>> - "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart" >> >> Ok! >> >>> >>> Also, you need to update drivers/soc/atmel/soc.c >> >> OK. Did you refer to CIDR, EXID registers? They are at the same offsets as >> for the old products. So we can rely on old compatible for them. Is this OK? >> > > Then, what is the point of adding microchip,sam9x60-dbgu ? Different meaning for CIDR register bits. Version is kept on bits 4 to 0 but not documented in public datasheet, so version displayed by drivers/soc/atmel/soc.c should work. Thank you, Claudiu Beznea > > > -- > Alexandre Belloni, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com >
