Hi, On Tue, Jan 7, 2020 at 3:30 AM Harigovindan P <harigovi@xxxxxxxxxxxxxx> wrote: > > + drm_panel_init(&ctx->panel); > + ctx->panel.dev = device; > + ctx->panel.funcs = &visionox_rm69299_drm_funcs; I haven't reviewed your whole panel driver, but I did just try to compile it and found that it won't compile against mainline. Namely this needs to be changed to: drm_panel_init(&ctx->panel, dev, &visionox_rm69299_drm_funcs, DRM_MODE_CONNECTOR_DSI); ...because of commit 6dbe0c4b0fc0 ("drm/panel: Initialise panel dev and funcs through drm_panel_init()") and commit 9a2654c0f62a ("drm/panel: Add and fill drm_panel type field") -Doug