On Thu, Jan 09, 2020 at 08:25:03AM +0000, Anson Huang wrote:
> Hi, Shawn
>
> > Subject: Re: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect
> > power supply assignment
> >
> > On Mon, Dec 30, 2019 at 09:41:07AM +0800, Anson Huang wrote:
> > > The vdd3p0's input should be from external USB VBUS directly, NOT
> >
> > Shouldn't USB VBUS usually be 5V? It doesn't seem to match 3.0V which is
> > suggested by vdd3p0 name.
> >
> > > PMIC's sw2, so remove the power supply assignment for vdd3p0.
> > >
> > > Fixes: 93385546ba36 ("ARM: dts: imx6qdl-sabresd: Assign corresponding
> > > power supply for LDOs")
> >
> > Is it only a description correcting or is it fixing a real problem? I'm trying to
> > understand it is a 5.5-rc material or can be applied for 5.6.
> >
>
> It is fixing a real problem about USB LDO voltage, that is why we noticed this issue.
Okay, please describe the problem a little bit in the commit log. Also
squash the series into one patch, which is easier to be merged into -rc
as a fix.
My question above that USB VUBS is 5V which doesn't match 3.0V
suggested by vdd3p0 name remains unaddressed though.
Shawn
