On 8 May 2014 13:12, Jingoo Han <jg1.han@xxxxxxxxxxx> wrote: > On Thursday, May 08, 2014 3:20 PM, Rahul Sharma wrote: >> >> From: Rahul Sharma <Rahul.Sharma@xxxxxxxxxxx> >> >> Enable dp-controller for snow board. >> >> Signed-off-by: Rahul Sharma <Rahul.Sharma@xxxxxxxxxxx> >> --- >> arch/arm/boot/dts/exynos5250-snow.dts | 27 +++++++++++++++++++++++++++ >> 1 file changed, 27 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts >> index 796954c..28a755f 100644 >> --- a/arch/arm/boot/dts/exynos5250-snow.dts >> +++ b/arch/arm/boot/dts/exynos5250-snow.dts >> @@ -207,6 +207,33 @@ >> }; >> }; >> >> + dp-controller@145B0000 { >> + status = "okay"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&dp_hpd>; >> + samsung,color-space = <0>; >> + samsung,dynamic-range = <0>; >> + samsung,ycbcr-coeff = <0>; >> + samsung,color-depth = <1>; >> + samsung,link-rate = <0x0a>; >> + samsung,lane-count = <2>; >> + samsung,hpd-gpio = <&gpx0 7 0>; >> + display-timings { > > For readability, please insert one line as below. > > + samsung,hpd-gpio = <&gpx0 7 0>; > + > + display-timings { > > The same comment applies to the 5th patch. > ([PATCH v2 5/5] ARM: dts: enable dp-controller for exynos5420 > based peach-pit board) > Ok. Will do that. Regards, Rahul Sharma. > Best regards, > Jingoo Han > >> + native-mode = <&timing1>; >> + timing1: timing@1 { >> + clock-frequency = <70589280>; >> + hactive = <1366>; >> + vactive = <768>; >> + hfront-porch = <40>; >> + hback-porch = <40>; >> + hsync-len = <32>; >> + vback-porch = <10>; >> + vfront-porch = <12>; >> + vsync-len = <6>; >> + }; >> + }; >> + }; >> + >> fimd@14400000 { >> status = "okay"; >> samsung,invert-vclk; >> -- >> 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html