From: Andrew Lunn <andrew@xxxxxxx> Date: Fri, 20 Dec 2019 16:33:59 +0100 > On Fri, Dec 20, 2019 at 06:57:12AM -0800, Richard Cochran wrote: >> On Tue, Dec 17, 2019 at 10:21:55AM +0100, Andrew Lunn wrote: >> > Forward declarations are considered bad. >> >> Not by me! > > Lets see what David says. I strongly dislike them too, it's indicative of poorly organized code. It's pointless and avoidable clutter, and always when they exist people never remember to remove them as code gets re-organized in the future. Yeah, avoid forward declarations for sure.