RE: [PATCHv2 1/2] usb: dwc2: Disable descriptor dma mode by default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> From: dinguyen@xxxxxxxxxx [mailto:dinguyen@xxxxxxxxxx]
> Sent: Tuesday, May 06, 2014 4:01 PM
> 
> Even though the IP supports Descriptor DMA mode, it does not support SPLIT
> transactions in this mode. So the driver, in its currently form, will not
> support LS/FS devices when connected to a HS Hub if Descriptor DMA mode is
> enabled.
> 
> So we disable descriptor dma mode by default and a provide device tree property
> for users to enable it if they really want to.

Hi Dinh,

I'd prefer not to add the DT property, at least for now. I doubt if
anyone will want to enable it. Besides, I'm not sure that a property
which only enables a driver feature is appropriate for DT.

So, if you redo patch 1 to remove the DT property read, and drop patch
2, you can add my acked-by. Thanks.

-- 
Paul

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux