Hi, On Wed, Dec 18, 2019 at 4:48 AM Sandeep Maheswaram (Temp) <sanm@xxxxxxxxxxxxxx> wrote: > > + "#address-cells": > + enum: [ 1, 2 ] > + > + "#size-cells": > + enum: [ 1, 2 ] > > Hm... ok. Interesting. > > Use of enum seems to match 'timer/arm,arch_timer_mmio.yaml'. ...and > sub-device probably uses DMA so IIUC it's important to pass > #size-cells of 2 down to it if the parent had it. > > Should i mention this as below? > > "#address-cells": > const: 2 > > "#size-cells": > const: 2 No, keep it like you have unless Rob disagrees. If the parent is only 32-bits it should be fine to keep it.