On Fri, 06 Dec 2019, Anand Moon wrote: > From: Daniel Schultz <d.schultz@xxxxxxxxx> > > Since all shutdown functions have almost the same code, all logic > from the shutdown functions can be refactored to a new function > "rk808_update_bits", which can update a register by a given address > and bitmask and value. > > link: https://lore.kernel.org/patchwork/patch/937404/ > Cc: Heiko Stuebner <heiko@xxxxxxxxx> > Signed-off-by: Daniel Schultz <d.schultz@xxxxxxxxx> > Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx> > --- > [rebased on latest kernel] > Modified the API to set the value. > This changes were submited with below patch. > [0] https://lore.kernel.org/patchwork/patch/937404/ > --- > drivers/mfd/rk808.c | 87 ++++++++++++++------------------------------- > 1 file changed, 26 insertions(+), 61 deletions(-) Not sure what's happening with these (competing?) patch-sets. I'm not planning on getting involved until you guys have arrived at and agreed upon a single solution. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog