On Mon, 09 Dec 2019, Sven Van Asbroeck wrote: > The driver has been extended to optionally get its operational > mode, regulator init data and LED naming from the devicetree. > > Tree: next-20191118 Please refrain from putting this in the commit message. > Acked-by: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > Signed-off-by: Sven Van Asbroeck <TheSven73@xxxxxxxxx> > --- ... if you really want to put that in, place it here, so it doesn't become part of the kernel's Git history. > .../devicetree/bindings/mfd/tps6105x.txt | 47 ++++++++++++++++++- > 1 file changed, 46 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mfd/tps6105x.txt b/Documentation/devicetree/bindings/mfd/tps6105x.txt > index 93602c7a19c8..d15763740a3f 100644 > --- a/Documentation/devicetree/bindings/mfd/tps6105x.txt > +++ b/Documentation/devicetree/bindings/mfd/tps6105x.txt > @@ -7,11 +7,56 @@ Required properties: > - compatible: "ti,tps61050" or "ti,tps61052" > - reg: Specifies the I2C slave address > > -Example: > +Optional sub-node: > + > +This subnode selects the chip's operational mode. > +There can be at most one single available subnode. > + > +- regulator: presence of this sub-node puts the chip in regulator mode. > + see Documentation/devicetree/bindings/regulator/regulator.txt Relative paths are preferred. > +- led: presence of this sub-node puts the chip in led mode. > + Optional properties: > + - function : see ../leds/common.txt > + - color : see ../leds/common.txt > + - label : see ../leds/common.txt Yes, like this. > + (deprecated) > + > +Example (GPIO operation only): > + > +i2c0 { > + tps61052@33 { > + compatible = "ti,tps61052"; > + reg = <0x33>; > + }; > +}; > + > +Example (GPIO + regulator operation): > > i2c0 { > tps61052@33 { > compatible = "ti,tps61052"; > reg = <0x33>; > + > + regulator { > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + regulator-always-on; > + }; > + }; > +}; > + > +Example (GPIO + led operation): > + > +#include <dt-bindings/leds/common.h> > + > +i2c0 { > + tps61052@33 { > + compatible = "ti,tps61052"; > + reg = <0x33>; > + > + led { > + color = <LED_COLOR_ID_WHITE>; > + }; > }; > }; -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog