Hi Xingyu and Rob, On Thu, Dec 12, 2019 at 1:20 PM Xingyu Chen <xingyu.chen@xxxxxxxxxxx> wrote: [...] > +examples: > + - | > + watchdog { > + compatible = "amlogic,meson-sec-wdt"; > + timeout-sec = <60>; > + }; in v3 of this patch Rob commented that there shouldn't be an OF node if there are no additional properties with timeout-sec there's now an additional property so my understanding is that it's fine to have an OF node what I don't understand yet is where this node should be placed. is it supposed to be a child node of the secure monitor node (for which we already have a binding here: Documentation/devicetree/bindings/firmware/meson/meson_sm.txt) or where else would we place it inside the .dts? Martin [0] https://patchwork.kernel.org/patch/11211399/