On 09. 12. 19 8:19, Guenter Roeck wrote: > On 12/8/19 10:42 PM, Michal Simek wrote: >> Hi, +Edgar >> >> >> On 08. 12. 19 23:38, Guenter Roeck wrote: >>> On Fri, Oct 18, 2019 at 06:07:31PM +0200, Michael Tretter wrote: >>>> From: Rajan Vaja <rajan.vaja@xxxxxxxxxx> >>>> >>>> Add firmware DT node in ZynqMP device tree. This node >>>> uses bindings as per new firmware interface driver. >>>> >>>> Signed-off-by: Rajan Vaja <rajanv@xxxxxxxxxx> >>>> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx> >>>> Signed-off-by: Michael Tretter <m.tretter@xxxxxxxxxxxxxx> >>> >>> With this patch applied in the mainline kernel, the qemu xlnx-zcu102 >>> emulation crashes (see below). Any idea what it might take to get >>> qemu back to working ? >> >> Driver talks through ATF to PMU unit(microblaze). I don't think A53+MB >> concept is working with mainline qemu. But crash is too hard. It should >> be no response from PMU and then this panic. >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/firmware/xilinx/zynqmp.c?h=v5.5-rc1#n728 >> >> > > Isn't that a bit harsh too ? Normally one would print an error message > and abort driver instantiation. Using different DT as Edgar mentioned should work but the question is how to properly wire it up. Edgar: What about "simply" generate that DT by qemu model based on what implementation is available? > > It sounds like you are saying that qemu's xlnx-zcu102 emulation is > no longer supported and expected to crash the kernel. Is this a > correct assumption ? If so, I'll drop it from my list of tests. Let's discuss this first. I definitely appreciate that you run these tests. Thanks, Michal
