Hi Rob. On Mon, Dec 02, 2019 at 08:38:39AM -0600, Rob Herring wrote: > On Sat, Nov 30, 2019 at 1:43 PM Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > > > > Hi Rob. > > > > Thanks for doing this boring, trivial and tiresome task. > > It was somewhat scripted at least... > > > On Tue, Nov 19, 2019 at 05:13:09PM -0600, Rob Herring wrote: > > > Convert all the 'simple' panels which either use the single > > > 'power-supply' property or don't say and just reference > > > simple-panel.txt. In the later case, bindings are clear as to which > > > properties are required or unused. > > > > > > Cc: Maxime Ripard <mripard@xxxxxxxxxx> > > > Cc: Chen-Yu Tsai <wens@xxxxxxxx> > > > Cc: Thierry Reding <thierry.reding@xxxxxxxxx> > > > Cc: Sam Ravnborg <sam@xxxxxxxxxxxx> > > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > > > > So Thierry and I ended up as Maintianes for them all. > > I gues thats OK as we look after the panel stuff anyway. > > > > > --- > > > We could perhaps consolidate a bunch of these, but I have no idea how > > > accurate some of these are WRT what's required or not. Seems strange > > > that 'backlight' is optional unless the backlight is tied full on for > > > example. If that's the case, then should backlight ever be required? > > I do not really follow you here. > > Looking through the patch set things looks normal to me. > > > > What do I miss here? > > I'm saying a bunch of these could just be a single schema doc with a > long list of compatibles. The variation is in what properties are > required or not. It would be just wonderful if we could have only a few dt-bindings for the simple panels. Like you I cannot see why enable-gpios should be required. We could end up with something like three classes of bindings: +required: + - compatible + - power-supply +required: + - compatible + - port + - power-supply +required: + - backlight + - compatible + - port + - power-supply The port part is to my best understanding a way to connect the panel to the display driver. So it should be more how the connect in the binding that decides if port is used or not. And the panel should not require it. I may use it with display drivers that do not support it in their binding. And then we have backlight - which can hardly be mandatory. The panel could hard-wire it to provide backligt if it wanted and the binding should continue to work. I think you had the same argument. So we are down to two required properties: +required: + - compatible + - power-supply Could we put all simple panels in one binding file with only this - that would be great. Hopefully scripted somehow... Then adding new simple panels would be a matter of adding a new compatible. And if they are sorted this should not cause many merge issues either. I hope I understood you correct. Sam
