Hi Geert, On Tue, Dec 3, 2019, Geert Uytterhoeven wrote: > > + reg = <0x3fefa000 0x100>, <0x18000000 > > + 0x4000000>; > > The second region conflicts with the XIP flash@18000000 in > arch/arm/boot/dts/r7s72100-gr-peach.dts. > Yes, I know it is the same device ;-) Is that just an FYI?? Or do you have some suggestion?? > > + clock-critical = <4>; /* spibsc0 */ > > Iff we go this clock-critical route, I think this should be specified in the > board-specific .dts instead of in the SoC-specific .dtsi. OK, that's fine. It makes more sense to be in the .dts because it's a board design decision. I will remove it from the patch. The one 'tricky' thing is that the <4> is the index into the number of clocks. So in the Renesas BSP where it includes the VDC5 LCD controllers, clock-output-names = "i2c0", "i2c1", "i2c2", "i2c3", "vdc50", "vdc51", "spibsc0", "spibsc1"; the <4> needs to become a <6>. Chris
