RE: [PATCH 1/6] clk: renesas: mstp: Add critical clock from device tree support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

Thank you for your review!

On Tue, Dec 3, 2019, Geert Uytterhoeven wrote:
> > +       unsigned long flags;
> 
> = 0 here...
> >
> > +               flags = 0;
> 
> ... instead of here?

That was my first thought too...and it was wrong.

If of_clk_detect_critical does NOT detect a critical clock, it does not 
touch flags at all.
And since it is a loop, what you get is after the first clock is marked 
as CRITICAL, all the remaining clocks also get marked CRITICAL. In this 
case, both spibsc0 and spibsc1 get marked critical. That's why I have to
reset it for each loop.

Chris





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux