Hi Chris,
On Tue, Dec 3, 2019 at 4:46 AM Chris Brandt <chris.brandt@xxxxxxxxxxx> wrote:
> Allow critical clocks to be specified in the Device Tree.
>
> Signed-off-by: Chris Brandt <chris.brandt@xxxxxxxxxxx>
Thanks for your patch!
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Notes:
1. Assumed we really need this,
2. Minor nit below.
> --- a/drivers/clk/renesas/clk-mstp.c
> +++ b/drivers/clk/renesas/clk-mstp.c
> @@ -187,6 +187,7 @@ static void __init cpg_mstp_clocks_init(struct device_node *np)
> const char *idxname;
> struct clk **clks;
> unsigned int i;
> + unsigned long flags;
= 0 here...
>
> group = kzalloc(struct_size(group, clks, MSTP_MAX_CLOCKS), GFP_KERNEL);
> if (!group)
> @@ -239,8 +240,11 @@ static void __init cpg_mstp_clocks_init(struct device_node *np)
> continue;
> }
>
> + flags = 0;
... instead of here?
> + of_clk_detect_critical(np, i, &flags);
> +
> clks[clkidx] = cpg_mstp_clock_register(name, parent_name,
> - clkidx, group);
> + clkidx, group, flags);
> if (!IS_ERR(clks[clkidx])) {
> group->data.clk_num = max(group->data.clk_num,
> clkidx + 1);
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
