On Sat, Nov 23, 2019 at 12:51:35PM +0000, Jonathan Cameron wrote: > If a function is your preferred route you could also just use it to compute > the values for the available table at startup? Yeah that makes sense. I'll add that in the next patchset version. > > The sampling ratio, frequency, etc code seems to be the most complicated part > > of the driver. Is it typically recommended to upstream a more minimal driver > > that might assume the defaults? > > Often people upstream a first version that just uses defaults, then follow > up (if they care) with later series adding the more fiddly elements. > > Sometimes those more fiddly bits never come as a particular author > never needed them. That's absolutely fine. It's a rare driver > that supports all the features on a non trivial device! Makes sense. I'll likely add some extra bits in a follow-up patchset, so I can learn a bit more. Cheers, - Dan
