On Tue, 5 Nov 2019 17:05:16 +0100
Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:
> > void drm_bridge_add(struct drm_bridge *bridge);
> > void drm_bridge_remove(struct drm_bridge *bridge);
> > struct drm_bridge *of_drm_find_bridge(struct device_node *np);
> > @@ -475,6 +543,56 @@ void drm_atomic_bridge_chain_pre_enable(struct drm_bridge *bridge,
> > void drm_atomic_bridge_chain_enable(struct drm_bridge *bridge,
> > struct drm_atomic_state *state);
> >
> > +void __drm_atomic_helper_bridge_reset(struct drm_bridge *bridge,
> > + struct drm_bridge_state *state);
> > +struct drm_bridge_state *
> > +drm_atomic_helper_bridge_reset(struct drm_bridge *bridge);
> > +void drm_atomic_helper_bridge_destroy_state(struct drm_bridge *bridge,
> > + struct drm_bridge_state *state);
> > +void __drm_atomic_helper_bridge_duplicate_state(struct drm_bridge *bridge,
> > + struct drm_bridge_state *new);
> > +struct drm_bridge_state *
> > +drm_atomic_helper_bridge_duplicate_state(struct drm_bridge *bridge);
> > +
> > +static inline struct drm_bridge_state *
> > +drm_atomic_get_bridge_state(struct drm_atomic_state *state,
> > + struct drm_bridge *bridge)
> > +{
> > + struct drm_private_state *obj_state;
> > +
> > + obj_state = drm_atomic_get_private_obj_state(state, &bridge->base);
> > + if (!obj_state)
> > + return NULL;
>
> drm_atomic_get_private_obj_state will return an error object on error, so should be:
> if (IS_ERR(obj_state))
> return ERR_CAST(obj_state);
Right, I'll fix it in v4.
Thanks,
Boris
