Hi Brian, On 30/04/2014 19:51, Brian Norris wrote: > Hi Boris, > > On Wed, Mar 12, 2014 at 07:07:36PM +0100, Boris BREZILLON wrote: >> + >> +/** >> + * struct nand_sdr_timings - SDR NAND chip timings >> + * >> + * This struct defines the timing requirements of a SDR NAND chip. >> + * These informations can be found in every NAND datasheets and the timings >> + * meaning are described in the ONFI specifications: >> + * www.onfi.org/~/media/ONFI/specs/onfi_3_1_spec.pdf (chapter 4.15 Timing > Can you remove the unicode U+200E character? Sure > >> + * Parameters) > Please document the units for these fields here. It looks like you're > using picoseconds. I'll add field units (which are indeed picoseconds) to this comment. Best Regards, Boris -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
