Hi Jerome,
On Tue, Nov 12, 2019 at 6:20 PM Jerome Brunet <jbrunet@xxxxxxxxxxxx> wrote:
>
>
> >> +static const struct of_device_id meson8_ddr_clkc_match_table[] = {
> >> + { .compatible = "amlogic,meson8-ddr-clkc" },
> >> + { .compatible = "amlogic,meson8b-ddr-clkc" },
> >> + { /* sentinel */ },
> >
> > Super nitpick, drop the comma above so that nothing can follow this.
>
> I don't think it is worth reposting the series Martin.
> If it is ok with you, I'll just apply it with Stephen comments
I am more than happy with this.
just to confirm, you would address all three comments from Stephen:
- including clk-provider.h
- use devm_platform_ioremap_resource
- trailing comma after the sentinel
> In the future, I would prefer if you could separate the series for clock
> (intended for Neil and myself) and the DT one (intended for Kevin)
sorry, we discussed this previously but I completely forgot about it
when I re-sent this series
I'll be more careful next time
Martin
